Fix the position of bound() in Container::instance() #19207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In instance() function, the code set the array of instances[$abstract]. And next, the code check to determine if type has been bound before,.However in bound(), isset(this->instances[$abstract]) always be true because it is set just in last line, and $this->isAlias($abstract) always be false because it just unset($this->aliases[$abstract]):
file: /illuminate/Container/Container.php-line356
file: /illuminate/Container/Container.php-line151
so rebound() function always fires incorrectly.
I change the position of bound() function, so it will not be affected by the code in the instance().
More detail can see issues #19194
thanks!