[5.4] Fixes and optimizations for Str::after#19428
Merged
taylorotwell merged 1 commit intolaravel:5.4from Jun 1, 2017
vlakoff:str-after
Merged
[5.4] Fixes and optimizations for Str::after#19428taylorotwell merged 1 commit intolaravel:5.4from vlakoff:str-after
taylorotwell merged 1 commit intolaravel:5.4from
vlakoff:str-after
Conversation
* Correct results if there are multibyte characters before the search * Do not trigger warning if search is an empty string Also, should be significantly faster.
vlakoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19357.
Also, should be significantly faster.
Unless I'm mistaken, here it should be fine to use single-byte functions.