Flip expected and actual value on assertCookie#19495
Merged
taylorotwell merged 1 commit intolaravel:5.4from Jun 6, 2017
eduPHP:patch-1
Merged
Flip expected and actual value on assertCookie#19495taylorotwell merged 1 commit intolaravel:5.4from eduPHP:patch-1
taylorotwell merged 1 commit intolaravel:5.4from
eduPHP:patch-1
Conversation
Problem:
Test:
```
$response->assertCookie("somecookie", 'expected');
```
Controller:
´´´
Cookie::queue('somecookie', 'actual value', $days);
´´´
phpunit
´´´
There was 1 failure:
1) Tests\Feature\LifetimeCookiesTest::by_accessing_the_affiliation_link_a_cookie_must_be_stored
Cookie [somecookie] was found, but value [actual] does not match [expected].
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'actual'
+'expected'
´´´
Solution:
Flip expected and actual values
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Test:
Controller:
phpunit
Solution:
Flip expected and actual values