[5.4] Adding missing locales to Translation MessageSelector#19562
Merged
Conversation
Contributor
|
Should this not target |
lucasmichot
reviewed
Jun 11, 2017
| case 'zh_SG': | ||
| case 'zh_TW': | ||
| return 0; | ||
| break; |
lucasmichot
reviewed
Jun 11, 2017
| case 'mg_MG': | ||
| case 'nso': | ||
| case 'nso_ZA': | ||
| case 'xbr': |
Contributor
There was a problem hiding this comment.
wbr should be after wa_BE
Contributor
Author
|
@lucasmichot Thanks for your review. I don't know if it should target the I'm using the version If I need to target the |
Member
|
5.4 is fine. It's basically a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations in the format below were returning the wrong plural with locales like
pt_BR, because it does not find the locale in the getPluralIndex and always returns the default0.