[5.4] Make RequestGuard Macroable#19569
Merged
taylorotwell merged 2 commits intolaravel:5.4from Jun 12, 2017
Merged
Conversation
use Illuminate\Support\Traits\Macroable;
Contributor
|
Tests ? |
ntzm
reviewed
Jun 12, 2017
src/Illuminate/Auth/RequestGuard.php
Outdated
| class RequestGuard implements Guard | ||
| { | ||
| use GuardHelpers; | ||
| use GuardHelpers,Macroable; |
Contributor
There was a problem hiding this comment.
Needs a space after the comma
Contributor
There was a problem hiding this comment.
psr-2 says There MUST be one use keyword per declaration
Contributor
There was a problem hiding this comment.
True @BrandonShar but in this case this is not a declaration.
Contributor
|
Could do with a better title for the PR! |
tillkruss
changed the title
Contributor
Author
|
Thank you, my English is not good, sorry. I am going to optimize the code tomorrow, I am now 1 o'clock now. I was doing api internal call need to expand some of the methods and found that not like SessionGuard, I Pull Request reasonable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for RequestGuard Class use Illuminate\Support\Traits\Macroable;
Similar to SessionGuard Class,Allows RequestGuard Class expansion Method.