[5.4] Make Arr::random($array, 1) return an array of one item#19826
Merged
taylorotwell merged 5 commits intolaravel:5.4from Jun 29, 2017
vlakoff:array_random_2
Merged
[5.4] Make Arr::random($array, 1) return an array of one item#19826taylorotwell merged 5 commits intolaravel:5.4from vlakoff:array_random_2
taylorotwell merged 5 commits intolaravel:5.4from
vlakoff:array_random_2
Conversation
Contributor
Author
Similarly to Collection::random()
Similarly to Collection::random(1)
Makes it less magical that it behaves differently when the parameter is omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19818.
A bit of proofreading would be welcome. For example I nearly forgot adding a
count(func_get_args())in the array_random() helper, which was necessary before I make the optional parameter no more "magical".