[5.4] Add Event timezone in inTimeInterval $now#19959
Merged
Merged
Conversation
It's will reduce timezone issue in scheduling, please have a look into this.
Contributor
|
Can you add a test for this, please? |
replace strtotime with Carbon parse.
Test case updated for Event timezone in inTimeInterval .
Contributor
Author
|
I've updated the test, please have a look into this, Thanks. |
lucasmichot
reviewed
Jul 8, 2017
| { | ||
| return function () use ($startTime, $endTime) { | ||
| $now = Carbon::now()->getTimestamp(); | ||
| $now = Carbon::now($this->timezone)->getTimestamp(); |
Contributor
There was a problem hiding this comment.
Why not just :
return Carbon::now($this->timezone)->between(
Carbon::parse($startTime, $this->timezone),
Carbon::parse($endTime, $this->timezone),
true
);?
Event time check method replace with carbon between.
Update code style
Contributor
Author
tillkruss
changed the title
Member
|
This changes code unrelated to the timezone. Only make the change specified in the title. |
Member
|
This fixes the following case: At I believe this fix is ok. |
Contributor
Author
|
Thank you guys 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's will reduce timezone issue in scheduling, please have a look into this.