Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[5.5] Use listensFor instead of hears for event listener self-registration #19962
I love the new feature introduced in #19917 and I wanted to make a naming suggestion, but I didn't see it until it was merged. There was a bit of discussion on that PR, but I'm sure Taylor and Mohammed get enough alerts without reading through closed PRs so I figured opening a new one would be the best way to propose it.
Here's my reasoning for the change copied from that thread: The reason I prefer
@adamwathan , would love to hear your thoughts since you introduced the feature. Of course, close away if this seems too pedantic, but I find naming to worth a discussion since it's both difficult and important. I'll still use and enjoy the feature regardless, but I might scoff a bit when I add my listeners array