[5.4] Use the correct user model namespace in make:policy Command - #19965
Merged
Conversation
ntzm
reviewed
Jul 8, 2017
| * Replace the user model for the given stub. | ||
| * | ||
| * @param string $stub | ||
| * @return string mixed |
Contributor
There was a problem hiding this comment.
@return string mixed isn't valid, should be just @return string
Contributor
Author
There was a problem hiding this comment.
Thanks, didn't notice that
Member
|
Hard-coding |
Contributor
Author
|
@taylorotwell Right, working on a fix |
4refael
reviewed
Jul 8, 2017
| */ | ||
| protected function replaceUserModelNamespace($stub) | ||
| { | ||
| return str_replace($this->rootNamespace().'User', config('auth.providers.users.model'), $stub); |
Contributor
There was a problem hiding this comment.
A slight improvement
if ($this->rootNamespace().'User' !== config('auth.providers.users.model')) {
return str_replace($this->rootNamespace().'User', config('auth.providers.users.model'), $stub);
}
return $stub;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been creating new policies this days in a project where my models are under app/Models directory.
Every policy I created I needed to modify the namespace of the user's model.
I remembered that this information is available through the auth configuration file and ended up with this.
I want to thank @JosephSilber who taught me a lot on this Gates & Policies stuff.