New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Add FileSystem temporaryUrl() method for aws #20375

Merged
merged 3 commits into from Aug 1, 2017

Conversation

Projects
None yet
5 participants
@themsaid
Member

themsaid commented Aug 1, 2017

Gives the ability to generate temporary links for a given file:

Storage::disk('s3')->temporaryUrl("path/to/file", Carbon::now()->addMinutes(10))

themsaid added some commits Aug 1, 2017

@taylorotwell taylorotwell merged commit bc9121c into laravel:5.4 Aug 1, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lk77

This comment has been minimized.

Show comment
Hide comment
@lk77

lk77 Aug 3, 2017

it would be cool to have it for other drivers too.

lk77 commented Aug 3, 2017

it would be cool to have it for other drivers too.

@Xantios

This comment has been minimized.

Show comment
Hide comment
@Xantios

Xantios Aug 3, 2017

and maybe not only for a duration but also for a amount of hits ? ( or im a thinking of a edge case here?)

Xantios commented Aug 3, 2017

and maybe not only for a duration but also for a amount of hits ? ( or im a thinking of a edge case here?)

@mhenkel1

This comment has been minimized.

Show comment
Hide comment
@mhenkel1

mhenkel1 Aug 4, 2017

It should be based on a time setting (minute) and an IP address.
I think your edge case has been solved with that. ;)

mhenkel1 commented Aug 4, 2017

It should be based on a time setting (minute) and an IP address.
I think your edge case has been solved with that. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment