New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FilesystemAdapter.php #20398

Merged
merged 3 commits into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@sausin
Contributor

sausin commented Aug 2, 2017

The current implementation does not allow other adapters a chance to implement a temporaryUrl() as the $adapter->getClient() gets called in first which is not how it works in all cases (in openstack for eg, there is no getClient() on the adapter).

This PR allows for this to be possible.

Update FilesystemAdapter.php
The current implementation does not allow other adapters a chance to implement a `temporaryUrl()` as the `$adapter->getClient()` gets called in first which is not how it works in all cases (in openstack for eg, there is no `getClient()` on the adapter).

This PR allows for this to be possible.
@taylorotwell

This comment has been minimized.

Member

taylorotwell commented Aug 2, 2017

Why are you not passing the rest of the arguments? Doesn't make sense.

sausin added some commits Aug 2, 2017

Fix
(I've gotta read sometimes...)
@sausin

This comment has been minimized.

Contributor

sausin commented Aug 2, 2017

@taylorotwell My bad. I was using defaults in my adapter for the other arguments and forgot to include parameters to this call.

PR is updated.

@taylorotwell taylorotwell merged commit e075523 into laravel:5.4 Aug 2, 2017

1 of 2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has failed - 1 file needs addressing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sausin sausin deleted the sausin:sausin-patch-1 branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment