[5.4] Fix JoinClause's whereIn when using a subquery#20453
Merged
taylorotwell merged 3 commits intolaravel:5.4from Aug 14, 2017
rtheunissen:rt-fix-join-wherein
Merged
[5.4] Fix JoinClause's whereIn when using a subquery#20453taylorotwell merged 3 commits intolaravel:5.4from rtheunissen:rt-fix-join-wherein
taylorotwell merged 3 commits intolaravel:5.4from
rtheunissen:rt-fix-join-wherein
Conversation
Contributor
Author
|
Thoughts on this @taylorotwell? We currently can't use subqueries in joins resulting in more queries than we'd like to be making. Should we use a fork in the meantime (rather than modified vendor files) or can we look at releasing this as a patch on 5.4? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
You should be able to pass an existing Builder to
whereInof aJoinClause, but this doesn't work because theif ($values instanceof static)doesn't catch the expected case when you pass aBuilderbecause it's not an instance ofJoinClause.TypeError: Argument 1 passed to Illuminate\Database\Grammar::parameterize() must be of the type array, object givenSteps To Reproduce: