Add Str::start() and str_start helper function - #20569
Merged
Merged
Conversation
Member
|
I accept your string helper offering. |
Contributor
|
Proud of you bud. |
Contributor
|
Should benchmark the regex implementation in this and If the code was significantly simpler with the regex I wouldn't even say anything, but actually feels more complicated than this: Maybe there's some other reason it needs to be fancy though? Entirely possible! (FWIW I would have PR'd it the exact same way you did, to be clear 😄) |
|
The helper man. Congrats @calebporzio 👌🏻 |
Contributor
|
@adamwathan The e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's life if you can't PR string helper functions - amiright?
With some naming help from twitter and @adamwathan, I planned on PRing
str_prefixandstr_suffix(Those were the helper functions @DanielCoulbourne and I talked about on the podcast) as a cure for the common and gnarly lookingltrim($path, '/').'/'andrtrim($path, '/').'/', but upon writing up tests discoveredstr_finishface palmI often need this sort of thing when dealing with urls and paths. Hopefully the need is felt.
Long live the string helper!