New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Removed optimize command #20771

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@DCzajkowski
Contributor

DCzajkowski commented Aug 26, 2017

Removed optimize command, since it was left empty anyway. Closes #20767

@DCzajkowski DCzajkowski changed the title from Removed optimize command, since it was left empty anyway to [5.5] Removed optimize command Aug 26, 2017

@sisve

This comment has been minimized.

Show comment
Hide comment
@sisve

sisve Aug 26, 2017

Contributor

It is being deprecated for one release, according to laravel/ideas#383

Contributor

sisve commented Aug 26, 2017

It is being deprecated for one release, according to laravel/ideas#383

@DCzajkowski

This comment has been minimized.

Show comment
Hide comment
@DCzajkowski

DCzajkowski Aug 26, 2017

Contributor

It is not a breaking change (since it won't destroy any codebase) and it isn't really deprecated. It is softly removed currently, which makes no sense whatsoever.

Contributor

DCzajkowski commented Aug 26, 2017

It is not a breaking change (since it won't destroy any codebase) and it isn't really deprecated. It is softly removed currently, which makes no sense whatsoever.

@taylorotwell

This comment has been minimized.

Show comment
Hide comment
@taylorotwell

taylorotwell Aug 26, 2017

Member

We'll remove it in 5.6 and note in the upgrade guide for 5.5. It can break deployment scripts that are calling it if we remove it without warning.

Member

taylorotwell commented Aug 26, 2017

We'll remove it in 5.6 and note in the upgrade guide for 5.5. It can break deployment scripts that are calling it if we remove it without warning.

@DCzajkowski

This comment has been minimized.

Show comment
Hide comment
@DCzajkowski

DCzajkowski Aug 26, 2017

Contributor

What about making it write to the console?:

[Warning] Deprecated ...
Contributor

DCzajkowski commented Aug 26, 2017

What about making it write to the console?:

[Warning] Deprecated ...
@decadence

This comment has been minimized.

Show comment
Hide comment
@decadence

decadence Aug 28, 2017

Contributor

Can somebody explain why this was deprecated and what is alternative?

Contributor

decadence commented Aug 28, 2017

Can somebody explain why this was deprecated and what is alternative?

@timacdonald

This comment has been minimized.

Show comment
Hide comment
@timacdonald

timacdonald Aug 29, 2017

Contributor

@decadence i think I remember Taylor maybe saying on a podcast that due to performance improvements in PHP itself (OPCache and whatnot) the command didn't really have any benifit anymore. Don't quote me on that...

Contributor

timacdonald commented Aug 29, 2017

@decadence i think I remember Taylor maybe saying on a podcast that due to performance improvements in PHP itself (OPCache and whatnot) the command didn't really have any benifit anymore. Don't quote me on that...

@decadence

This comment has been minimized.

Show comment
Hide comment
@decadence

decadence Aug 29, 2017

Contributor

@timacdonald thanks

Contributor

decadence commented Aug 29, 2017

@timacdonald thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment