New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Add dusk blade directive #20816

Closed
wants to merge 2 commits into
base: 5.5
from

Conversation

Projects
None yet
3 participants
@calebporzio
Contributor

calebporzio commented Aug 29, 2017

This PR is a compliment to an open dusk PR: laravel/dusk#347

It prevents the @dusk directive from being ignored in production because DuskServiceProvider isn't loaded in production.

<div @dusk('foo')></div> // production markup without this PR 
<div ></div> // with PR
@deleugpn

This comment has been minimized.

Show comment
Hide comment
@deleugpn

deleugpn Aug 29, 2017

Contributor

A LOT cleaner.

Contributor

deleugpn commented Aug 29, 2017

A LOT cleaner.

@tillkruss tillkruss changed the title from Add dusk blade directive to [5.5] Add dusk blade directive Aug 30, 2017

@GrahamCampbell GrahamCampbell changed the base branch from master to 5.5 Aug 30, 2017

@taylorotwell

This comment has been minimized.

Show comment
Hide comment
@taylorotwell

taylorotwell Sep 5, 2017

Member

Closing pending inactivity. Resend if you want to finish it off.

Member

taylorotwell commented Sep 5, 2017

Closing pending inactivity. Resend if you want to finish it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment