New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad performance of resolve queueable entity #21583

Closed
wants to merge 1 commit into
base: 5.2
from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

fix bad performance of resolve queueable entity

  • Loading branch information...
tongjishi
tongjishi committed Oct 8, 2017
commit da2303c519cb08cf6aedca73b33be029f9345066
@@ -187,7 +187,7 @@ protected function resolveQueueableEntities($data)
*/
protected function resolveQueueableEntity($value)
{
if (is_string($value) && Str::startsWith($value, '::entity::')) {
if (is_string($value) && strpos($value, '::entity::') === 0) {
list($marker, $type, $id) = explode('|', $value, 3);
return $this->getEntityResolver()->resolve($type, $id);
ProTip! Use n and p to navigate between commits in a pull request.