New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Handle a case in Collection::where() for objects that can be casted to string #22295

Merged
merged 2 commits into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@themsaid
Member

themsaid commented Dec 4, 2017

$c = new Collection([['v' => 1], ['v' => new \Illuminate\Support\HtmlString('hello')]]);

$c->where('v', 'hello')->values()->all();

The changes in this PR will ensure the comparison occurs when the values are both strings or castable to strings.

themsaid added some commits Dec 4, 2017

@taylorotwell taylorotwell merged commit 44234cc into laravel:5.5 Dec 4, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment