New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Make the Command class macroable #22426

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
4 participants
@m1guelpf
Contributor

m1guelpf commented Dec 14, 2017

This PR makes the Command class macroable, making in easy to add custom functionality like in #22351.

:octocat:

@sisve

This comment has been minimized.

Show comment
Hide comment
@sisve

sisve Dec 14, 2017

Contributor

You're already supposed to create your own classes that derives from Command. That's not the case for many other macroable classes (like Collection or Blueprint). This means that all use-cases that a macroable Command would support can already be done by adding code (or a trait) to your existing command.

Contributor

sisve commented Dec 14, 2017

You're already supposed to create your own classes that derives from Command. That's not the case for many other macroable classes (like Collection or Blueprint). This means that all use-cases that a macroable Command would support can already be done by adding code (or a trait) to your existing command.

@taylorotwell taylorotwell merged commit 1604267 into laravel:5.5 Dec 14, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m1guelpf m1guelpf deleted the m1guelpf-forks:patch-1 branch Dec 14, 2017

@browner12

This comment has been minimized.

Show comment
Hide comment
@browner12

browner12 Dec 14, 2017

Contributor

yah, I thought the point of Macroables was so we could change code that wasn't in userland?

Contributor

browner12 commented Dec 14, 2017

yah, I thought the point of Macroables was so we could change code that wasn't in userland?

@GrahamCampbell GrahamCampbell changed the title from Make the Command class macroable to [5.5] Make the Command class macroable Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment