[5.6] ResourceResponse returns the resource data instead of JSON on Original#22455
Merged
taylorotwell merged 3 commits intolaravel:masterfrom Dec 18, 2017
olivernybroe:Origin-on-resource
Merged
[5.6] ResourceResponse returns the resource data instead of JSON on Original#22455taylorotwell merged 3 commits intolaravel:masterfrom olivernybroe:Origin-on-resource
taylorotwell merged 3 commits intolaravel:masterfrom
olivernybroe:Origin-on-resource
Conversation
Contributor
Author
|
The reason for setting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By setting original to the model on resources, we can in our tests check directly if the model is the correct one, by just getting the original attribute on the response.
Often I don't want to check if the JSON is formatted correctly, just interested if the model is the correct one.
Pull request send to master instead of 5.5, as commented in #22429