[5.6] Allow to fetch specific key when using json helper

[jerguslejko]

This PR allows to fetch a specific key off of the TestResponse class.

Example:

$title = $this->post('/posts', $data)
    ->json('data.title');

vs

$title = $this->post('/posts', $data)
    ->json()['data']['title'];

🌵

[jkniest]

This should be @param string|null $key if I'm not wrong

[jerguslejko]

Oh thanks!

[jkniest]

Same as above: This should be:

@param string|null $key 

if I'm not wrong

[mfn]

If in the old version, data or title was missing or title, you would get an immediate error (which I consider good).

OTOH with data_get you will always receive a value (default value) back and your test breaks at a later point.

Not sure I would consider that an improvement?

Iff it didn't matter for I test I would probably write ->json()['data']['title'] ?? ''.

[sisve]

A quick reminder that even the TestResponse class is a documented public api. Changing a method signature in a public api is a breaking change. Have you considered targeting the 5.6 release?

[jkniest]

But this change, as I see it, is completley optional. You don't need to pass a key in it. So it would not "break" anything and it would still be useable like before the change.

[jkniest]

If the $key is null, which it is by default, the normal object will be returned like before.

https://github.com/illuminate/support/blob/master/helpers.php#L454

[sisve]

The breaking isn't for those that call the method, but for those that have overridden it. You will get php warnings stating that your model signature does not match the signature that you are overriding.

[GrahamCampbell]

return type is now wrong

[GrahamCampbell]

return type is now wrong

[sisve]

Could you change the targeted branch to master to target the 5.6 release since this has breaking changes (changes to method signatures)?

[jerguslejko]

Honestly, I do not consider this PR to be a breaking change. I'd like it to be merged into 5.5 so it becomes available right away.

[devcircus]

I hate these back-and-forths on breaks, however, whether something is a BC break does not change if you don't agree. It either is or isn't. Technically, if the class isn't declared final, adding a parameter ( even with a default value) is a BC break. If the method is being overwritten (likely), then that app will break. Period.

Should target master, as we shouldn't intentionally break people's apps unless it is an important bug fix(this is not), but that's definitely up to Taylor.