Skip to content

[5.6] Fix inOrder assertions - #23038

Merged
taylorotwell merged 2 commits into
laravel:5.6from
mnabialek:5.6-assert-order-fixes
Feb 5, 2018
Merged

[5.6] Fix inOrder assertions#23038
taylorotwell merged 2 commits into
laravel:5.6from
mnabialek:5.6-assert-order-fixes

Conversation

@mnabialek

Copy link
Copy Markdown
Contributor

This fixes @helmut #22915

In previous implementation when response contained foo bar foo and you ran:

$response->assertSeeInOrder(['foo', 'bar', 'foo']);

it failed and now it will pass.

Also tests updated a bit just to make sure both assertions fail as expected in tests.

@taylorotwell
taylorotwell merged commit 09a1448 into laravel:5.6 Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants