[5.6] Dropdown nav accessibility fix#23191
Merged
Merged
Conversation
austintoddj
added a commit
to austintoddj/zoom
that referenced
this pull request
Feb 17, 2018
austintoddj
added a commit
to austintoddj/zoom
that referenced
this pull request
Feb 17, 2018
* feature/v3: Update navbar laravel/framework#23191 Asset fixes Apply fixes from StyleCI (#20) Add socialite fuctionality Asset updates and tests Navbar accessibility update laravel/framework@07950f9 Blade updates and directory refactor Apply fixes from StyleCI (#19) Package updates and helper classes Models directory refactor Updated composer config and webpack Updated the readme Update npm to yarn Adds travis config Apply fixes from StyleCI (#18) Update the .env variables Fresh L5.6 installation
austintoddj
added a commit
to austintoddj/zoom
that referenced
this pull request
Feb 17, 2018
* release/2.1.0: Update navbar laravel/framework#23191 Asset fixes Apply fixes from StyleCI (#20) Add socialite fuctionality Asset updates and tests Navbar accessibility update laravel/framework@07950f9 Blade updates and directory refactor Apply fixes from StyleCI (#19) Package updates and helper classes Models directory refactor Updated composer config and webpack Updated the readme Update npm to yarn Adds travis config Apply fixes from StyleCI (#18) Update the .env variables Fresh L5.6 installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the dropdown menu was being labeled by
navbarDropdown, the corresponding ID needed to be added to the clickable element. The Bootstrap 4 docs include this change.