[5.6] Rewrite BadMethodCallException messages for consistency and always include the FQN of the class that throws the exception#23232
Merged
Conversation
…clude the FQN of the class that generates the exception
gregoriohc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The objective of the proposed changes is to make the messages of the
BadMethodCallExceptionexceptions more consistent in the framework, always including the FQN of the class where the exceptions is thrown, since in many cases the exception is thrown by a trait (ex:Macroable) making the debugging more complicated.This way, what would previously generate an error by console with this message:
Now it generates the following message:
The tests have also been updated to reflect the changes.