[5.6] Add ability to extend DatabaseNotification model attributes on create#23337
Merged
taylorotwell merged 3 commits intoFeb 28, 2018
Merged
[5.6] Add ability to extend DatabaseNotification model attributes on create#23337taylorotwell merged 3 commits into
taylorotwell merged 3 commits into
Conversation
antonkomarev
deleted the
feature/extend-database-notification-model-payload
branch
February 28, 2018 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building of attributes array for the
Illuminate\Notifications\DatabaseNotificationmodel insideIlluminate\Notifications\Channels\DatabaseChannelextracted to method, what allow us to extend or overwrite default attributes.I found it useful because I were needed to add
seen_atand some more attributes related to my application and were needed to extend defaultDatabaseNotificationmodel. And instead just modifying attributes inDatabaseChannelclass on notification creation, we need to copy-pastesendmethod. That means that if there will be changes insendmethod in the future - we will require to update extended implementations.With this change we can do:
Additionally it helps us to keep the code DRY.