[5.6] Prevent considering an array attribute as callable in model factories

[themsaid]

Having:

$factory->define(App\User::class, function (Faker $faker) {
    return [
        'name' => ['Storage', 'Bar'],
    ];
});

While building the factory, is_callable(['Storage', 'Bar']) will return true so the code will try to call the Bar method on the Storage class and that'll error.

In this PR we exclude array forms from being dealt with as callables.

[roberto-aguilar]

Wow, that's a very curious finding @themsaid, nice catch!

I just have a question, what is the real use case behind this? when do you want to declare a factory that has one array as property?, i tried this case with a non existent class (and therefore a not existen method) and it throws a:

Illuminate\Database\QueryException with message 'PHP Notice: Array to string conversion.

On the contrary, i think that it will be useful to be able to still be able to do this:

$factory->define(App\User::class, function () {
    return [
        'lorem' => [new App\Ipsum, 'create'],
    ];
});

as proposed in #20692

[devcircus]

Check #23361 for the use case that discovered the bug.

[roberto-aguilar]

Oh, i get it now, a json casteable attribute, thanks @devcircus 👍

[themsaid]

@DojoGeekRA I was surprised it's not discovered earlier actually :)

[roberto-aguilar]

Yeah, me too, and even more considering that i use that kind of attributes a lot 😅

I totally agree with the fix then, thanks @themsaid!