You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@devcircus I was under the same impression based on information I found on stackoverflow and Laracasts forum.
I see the dispatchNow fallback behavior on Dispatcher@dispatch, however, executing a Job from within a Controller for example, that is meant to perform an action and return data back synchronously is actually returned with an instance of PendingDispatch
Ahh yes for Dispatchable, that is true. The DispatchesJobs trait is included by default in the base controller and has both "dispatch" and "dispatchNow".
Also, I tested on a project I'm working on and had forgotten I had made a custom dispatch method that handled async and sync jobs.
jrseliga
changed the title
Add dispatchNow to Dispatchable Trait.
[5.6] Add dispatchNow to Dispatchable Trait.
Mar 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@taylorotwell I wasn't sure if tests were necessary, as
BusDispatcherTest@testDispatchNowShouldNeverQueueseems to cover this.