[5.6] Remove attribute filling from pivot model#23401
Merged
taylorotwell merged 2 commits intolaravel:5.6from Mar 6, 2018
staudenmeir:5.6
Merged
[5.6] Remove attribute filling from pivot model#23401taylorotwell merged 2 commits intolaravel:5.6from staudenmeir:5.6
taylorotwell merged 2 commits intolaravel:5.6from
staudenmeir:5.6
Conversation
Contributor
|
Do not change the tests, add new tests instead. |
Contributor
Author
|
I replaced the test because it didn't seem to test double mutation, since there aren't any mutators in the model stub. Also, having tests called |
Contributor
|
Hi, Any chance this could be merged into 5.5? I am not sure about how you guys handle previous versions... |
taylorotwell
pushed a commit
that referenced
this pull request
Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When querying a pivot relationship with a specified model (
using()) the attributes are set usingforceFill(), causing custom mutators to be called.This is inconsistent with non-pivot models and also unnecessary, since the values are immediately overwritten with the raw attributes.
Fixes #23234.