Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Add dropMorphs to Blueprint #23431

Closed
wants to merge 6 commits into from

Conversation

adammparker
Copy link
Contributor

Resubmitting as suggested in #23400

What about tests for SQLite?

@jmarcher This is similar to dropTimestamps() and is not tested for the same reason. Both are incompatible with SQLite's restriction on dropping more than one column per 'transaction'.

Probably would need to drop the index as well. Feel free to re-submit if you want.

@taylorotwell Done.

@taylorotwell
Copy link
Member

Doc block is wrong.

@taylorotwell
Copy link
Member

Doc block still has extra line between params and return which no other docblocks do.

@taylorotwell
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants