Skip to content

[5.6] Add dropMorphs to Blueprint#23431

Closed
adammparker wants to merge 6 commits into
laravel:5.6from
adammparker:blueprint-dropmorph
Closed

[5.6] Add dropMorphs to Blueprint#23431
adammparker wants to merge 6 commits into
laravel:5.6from
adammparker:blueprint-dropmorph

Conversation

@adammparker
Copy link
Copy Markdown
Contributor

Resubmitting as suggested in #23400

What about tests for SQLite?

@jmarcher This is similar to dropTimestamps() and is not tested for the same reason. Both are incompatible with SQLite's restriction on dropping more than one column per 'transaction'.

Probably would need to drop the index as well. Feel free to re-submit if you want.

@taylorotwell Done.

@taylorotwell
Copy link
Copy Markdown
Member

Doc block is wrong.

@taylorotwell
Copy link
Copy Markdown
Member

Doc block still has extra line between params and return which no other docblocks do.

@taylorotwell
Copy link
Copy Markdown
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants