New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Signed Routes #23519

Merged
merged 12 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@taylorotwell
Member

taylorotwell commented Mar 13, 2018

This implements the ability to generate signed (and tempoorary) URLs. These URLs may be easily verified as having been generated by your application and not modified by the end-user.

taylorotwell added some commits Mar 12, 2018

@taylorotwell taylorotwell merged commit 3ed733f into 5.6 Mar 13, 2018

4 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/styleci/push The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@taylorotwell taylorotwell deleted the signed-routes branch Mar 13, 2018

@garygreen

This comment has been minimized.

Contributor

garygreen commented Mar 13, 2018

Related: #17499

Maybe the password reset system could use this?

@tillkruss

This comment has been minimized.

Member

tillkruss commented Mar 16, 2018

@garygreen: I'll make a PR in a few days.

@GrahamCampbell GrahamCampbell changed the title from Signed Routes to [5.6] Signed Routes Mar 17, 2018

@tillkruss

This comment has been minimized.

Member

tillkruss commented Mar 23, 2018

I've had a closer look at this and changed my mind. The signed routes are great, but the original approach of #17499 is way better IMO. I can reboot that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment