[5.6] Add thenPingIf and pingBeforeIf

[ThunderBirdsX3]

In case of you want to ping in specific condition.

$schedule->command('something')
         ->everyMinute()
         ->pingBeforeIf(app()->environment() == 'production', $url)
         ->thenPingIf(app()->environment() == 'production', $url);

[sailingdeveloper]

To be consistent with when on the Builder and Collection, shouldn't it be pingBeforeWhen and thenPingWhen?

[timodejong95]

@ThunderBirdsX3 ?

[ThunderBirdsX3]

I don't know. I just use thenPingIf and pingBeforeIf for no reason.

I think you must to ask @taylorotwell . Why it shouldn't it be pingBeforeWhen and thenPingWhen?

[timodejong95]

@ThunderBirdsX3 thenPingWhen and pingBeforeWhen should be more consistent with the current Laravel code like @sailingdeveloper mentioned previously.

Also here is an example: https://laravel.com/docs/5.6/blade#including-sub-views here includeIf is more a if exists do it and includeWhen is conditional based.

@taylorotwell Do you agree?