Repository navigation
[5.6] Fix $withCount binding problems - #24240
Merged
Merged
Conversation
Member
|
Is this only present when populating the $withCount property on the model directly? |
Contributor
Author
|
I would say that it's only a problem when |
Closed
This was referenced Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model::newQueryWithoutScopes()adds$withand$withCountto every query.This can cause problems if a
$withCountrelation has bindings (#23957, #22285, #21472, #21464, #21116).It's also unnecessary for INSERT/UPDATE/DELETE queries.
This PR adds
Model::newUneagerQueryWithoutScopes()which creates a query without$with&$withCount.Should I add additional (integration) tests?
Since this is the better solution for #23957: Should we revert #24000 (in case a nested where can legitimately have other bindings)?