[5.6] Fix loadMissing() relationship parsing#24329
Merged
Merged
Conversation
Contributor
|
Seems like there is a problem when using relations of the same name like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadMissing()currently parses nested relationships in a way that supports specifc columns in all levels:However, this is different from the way
load()andwith()parse relationships. They only support specific columns in the last relationship. This is necessary to allow columns with table names (#24166 (comment)):This PR adjusts the parsing to match
load()andwith().