[5.6] Add hint to mail fake#24911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Laravel, you have to use different assertions in tests depending on if you’re queuing a mailable, or immediately sending one.
The head of development at the company I work for has just spent some time trying to test a mailable was sent that he was actually queuing. I’ve made the mistake myself in the past. I’m sure countless other developers have too.
Given that developers of all skill levels get bit by this, I’m proposing to amend the error message in
assertSent()to append “Did you mean to use assertQueued() instead?” if there is one or more queued mailables. This should hopefully save a few developer headaches in the future!