[5.8] Add previous method to UrlGenerator interface #25616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
is there a place we can start tracking these breaking changes right away so it's easier for us to write a good upgrade guide for 5.8? do we just start the upgrade guide for 5.8 right now? |
|
@browner12 , maybe it will be better to have changelog within this repository? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UrlGenerator interface does not contain the previous() method that is implemented by the UrlGenerator class
Adding it allows me to use previous() while referencing the interface (and keep my IDE happy).
It would add an extra burden on other implementations of that interface that are out in the wild, making it a breaking change.
(Reapplied #25609 to master instead of 5.7)