New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] DB seed function in testing now accept an array too #26734

Merged
merged 4 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@johannebert
Contributor

johannebert commented Dec 4, 2018

This pull requests add the ability to accept an array of seed classes too.

/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase@seed

馃榾

@johannebert johannebert force-pushed the johannebert:5.7 branch from ad4de9a to 1e51748 Dec 4, 2018

@jmarcher

This comment has been minimized.

Contributor

jmarcher commented Dec 4, 2018

I do not feel like introducing this new dependency brings many benefits. Please explain why this change is needed.

@johannebert

This comment has been minimized.

Contributor

johannebert commented Dec 4, 2018

I do not feel like introducing this new dependency brings many benefits. Please explain why this change is needed.

Hey, in my case of testing i have many seed classes and to run them specific for particular test to really speed up the test suite.
Why should i run complete DatabaseSeeder if i only need a couple of them. And because it may be more than one seed class it would be great to run them in one function that accept also an array.

taylorotwell added some commits Dec 4, 2018

@taylorotwell taylorotwell merged commit ee01074 into laravel:5.7 Dec 4, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment