Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add Deferred interface for service providers #27067

Merged
merged 3 commits into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@svenluijten
Copy link
Contributor

commented Jan 4, 2019

As discussed and explained in laravel/ideas#1453.

If accepted, I will also update the documentation to only recommend using this interface, and leave the $defer property undocumented. This way we can remove the property altogether from the 5.9 release (or 5.10, whichever is preferred).

svenluijten added some commits Jan 4, 2019

@imanghafoori1

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2019

You may change the name of the interface from Deferred to
DeferredProvider or DeferredServiceProvider

That name is too short, I think...

@taylorotwell

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

I would call the interface "DeferrableProvider"

@taylorotwell taylorotwell merged commit e5bf646 into laravel:master Jan 5, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

svenluijten added a commit to svenluijten/docs that referenced this pull request Jan 5, 2019

@svenluijten svenluijten deleted the svenluijten:deferred-interface branch Jan 10, 2019

driesvints added a commit to driesvints/framework that referenced this pull request Feb 7, 2019

Indicate defer property removal
This property was deprecated by an alternative implementation in laravel#27067 and should be removed in the next major release.

taylorotwell pushed a commit to illuminate/support that referenced this pull request Feb 7, 2019

Indicate defer property removal
This property was deprecated by an alternative implementation in laravel/framework#27067 and should be removed in the next major release.

TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 17, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`

TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 17, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons`
- property `bindings`

TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 17, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`

TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 18, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 18, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

TBlindaruk added a commit to TBlindaruk/laravel-framework that referenced this pull request Feb 18, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/auth that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/auth that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/broadcasting that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/broadcasting that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/bus that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/bus that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/cache that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/cache that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/contracts that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/contracts that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/hashing that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/log that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/log that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/mail that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/mail that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/notifications that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/notifications that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/pagination that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/pagination that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/pipeline that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/pipeline that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/queue that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/queue that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/redis that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/redis that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/routing that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/routing that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/session that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/session that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/support that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/support that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/translation that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/translation that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/validation that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/validation that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

taylorotwell pushed a commit to illuminate/view that referenced this pull request Feb 23, 2019

[5.8] Make `register` method in the ServiceProvider as part of the co…
…ntract

 In the laravel/framework#27067 pr was added DeferrableProvider service provider.
 This Pr will add pretty the same thing.
 In case, if it will be accepted then I will add documentation for this.

----------------

Also i thing will be good to add diferent contract for the:
- method `boot`
- property `singletons` and `bindings`

taylorotwell pushed a commit to illuminate/view that referenced this pull request Feb 23, 2019

Revert "[5.8] Make `register` method in the ServiceProvider as part o…
…f the contract In the laravel/framework#27067 pr was added DeferrableProvider service provider.  This Pr will add pretty the same thing.  In case, if it will be accepted then I will add documentation for this."

This reverts commit f7fc225

luceos added a commit to tenancy/multi-tenant that referenced this pull request Feb 27, 2019

Laravel 5.8 Compatibility (#731)
As per Laravel 5.8 the Defer variable in Service Providers is [deprecated](laravel/framework#27067). This PR simply fixes the deferrable provider per their requirements, would break compatibility with 5.7 though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.