New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Bug Fix: Allow Null Broadcast Connection Driver #27135

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@ahinkle
Copy link
Contributor

ahinkle commented Jan 11, 2019

Fixes #27132

via Docs:

Additionally, a null driver is included which allows you to totally disable broadcasting

However, BROADCAST_DRIVER=null returns Broadcaster [] is not defined. within app.

This PR will allow a null Broadcast Driver to be disabled within the app.

@@ -269,7 +265,11 @@ protected function createNullDriver(array $config)
*/
protected function getConfig($name)
{
return $this->app['config']["broadcasting.connections.{$name}"];
if (! is_null($name) && $name !== 'null') {

This comment has been minimized.

@mfn

mfn Jan 11, 2019

Contributor

BROADCAST_DRIVER=null

Can you explain why the special case needs to be done in the $name ? Thanks

@X-Coder264

This comment has been minimized.

Copy link
Contributor

X-Coder264 commented Jan 11, 2019

I think that basically the same fix has been applied to the queue manager in Laravel 5.2 -> #11664

@taylorotwell taylorotwell merged commit 6d42c21 into laravel:5.7 Jan 11, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment