New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Re-throw NoMatchingExpectationException from PendingCommand #27158

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@meyerluk
Copy link
Contributor

meyerluk commented Jan 14, 2019

PendingCommand should re-throw NoMatchingExpectationException if $e->getMethodName() does not contain "askQuestion".

The $exitCode variable will not be present if the console kernel call throws a NoMatchingExpectationException and will abort at line 145 with:

ErrorException : Undefined variable: exitCode

imho the exception should be re-thrown.

@driesvints driesvints changed the title Re-throw NoMatchingExpectationException from PendingCommand [5.7] Re-throw NoMatchingExpectationException from PendingCommand Jan 14, 2019

@taylorotwell taylorotwell requested a review from themsaid Jan 14, 2019

@nunomaduro

This comment has been minimized.

Copy link
Member

nunomaduro commented Jan 14, 2019

Had this issue before - I end up always adding that piece of code on the vendor. Let's wait for @themsaid to review the proposed solution.

@themsaid themsaid merged commit d5d7259 into laravel:5.7 Jan 14, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@themsaid

This comment has been minimized.

Copy link
Member

themsaid commented Jan 14, 2019

This makes sense yes. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment