New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Apply parameters to entire localization array #27254

Merged
merged 4 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@Tekner
Copy link
Contributor

Tekner commented Jan 21, 2019

I apologize if this has been addressed somewhere else, though I was unable to find any discussion of this when searching for it. I found a discrepancy when apply parameter replacements to key-based localizations.

When calling

__('foobar', ['foo' => 'bar']);

to retrieve an entire localization array, the parameters are not applied. This minor change applies parameters to all lines retrieved.

Tekner added some commits Jan 21, 2019

Apply parameters to entire localization array
When calling
```php
__('foobar', ['foo' => 'bar']);
```
to retrieve an entire localization array, the parameters are not applied. This minor change applies parameters to all lines retrieved.

@driesvints driesvints changed the title Apply parameters to entire localization array [5.7] Apply parameters to entire localization array Jan 22, 2019

@taylorotwell taylorotwell merged commit bc4b00b into laravel:5.7 Jan 23, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Tekner Tekner deleted the Tekner:patch-1 branch Jan 23, 2019

@TBlindaruk

This comment has been minimized.

Copy link
Member

TBlindaruk commented Jan 27, 2019

@Tekner , Could you please add test for this case?

@TBlindaruk TBlindaruk referenced this pull request Jan 27, 2019

Closed

Add tests for the PR #27321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment