Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[5.7] Apply parameters to entire localization array #27254
+4
−0
Conversation
Tekner
added some commits
Jan 21, 2019
driesvints
changed the title
Apply parameters to entire localization array
[5.7] Apply parameters to entire localization array
Jan 22, 2019
taylorotwell
merged commit bc4b00b
into
laravel:5.7
Jan 23, 2019
Tekner
deleted the
Tekner:patch-1
branch
Jan 23, 2019
This comment has been minimized.
This comment has been minimized.
|
@Tekner , Could you please add test for this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Tekner commentedJan 21, 2019
I apologize if this has been addressed somewhere else, though I was unable to find any discussion of this when searching for it. I found a discrepancy when apply parameter replacements to key-based localizations.
When calling
__('foobar', ['foo' => 'bar']);to retrieve an entire localization array, the parameters are not applied. This minor change applies parameters to all lines retrieved.