Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[5.7] Revert and fix #26158 #27277
+40
−7
Conversation
This comment has been minimized.
This comment has been minimized.
|
The builds were timing out for a random reason so I restarted them. |
taylorotwell
merged commit c3f3022
into
laravel:5.7
Jan 23, 2019
staudenmeir
deleted the
staudenmeir:26158
branch
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
staudenmeir commentedJan 23, 2019
#26158 replaced
newQuery()withnewModelQuery()in UPDATE/DELETE queries to remove the unnecessary$withand$withCountrelationships.That's obviously incorrect, as it also removes global scopes. We have to use
newQueryWithoutRelationships()instead ofnewModelQuery().I added an integration test to prevent this from happening again.
Fixes #27266.