Skip to content

[5.7] Revert and fix #26158 - #27277

Merged
taylorotwell merged 1 commit into
laravel:5.7from
staudenmeir:26158
Jan 23, 2019
Merged

taylorotwell merged 1 commit into
laravel:5.7from
staudenmeir:26158

Conversation

@staudenmeir

Copy link
Copy Markdown
Contributor

#26158 replaced newQuery() with newModelQuery() in UPDATE/DELETE queries to remove the unnecessary $with and $withCount relationships.

That's obviously incorrect, as it also removes global scopes. We have to use newQueryWithoutRelationships() instead of newModelQuery().

I added an integration test to prevent this from happening again.

Fixes #27266.

@driesvints

Copy link
Copy Markdown
Member

The builds were timing out for a random reason so I restarted them.

@taylorotwell
taylorotwell merged commit c3f3022 into laravel:5.7 Jan 23, 2019
@staudenmeir
staudenmeir deleted the 26158 branch January 23, 2019 18:19
salmanarshad321 pushed a commit to salmanarshad321/framework that referenced this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants