New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Revert and fix #26158 #27277

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@staudenmeir
Copy link
Contributor

staudenmeir commented Jan 23, 2019

#26158 replaced newQuery() with newModelQuery() in UPDATE/DELETE queries to remove the unnecessary $with and $withCount relationships.

That's obviously incorrect, as it also removes global scopes. We have to use newQueryWithoutRelationships() instead of newModelQuery().

I added an integration test to prevent this from happening again.

Fixes #27266.

@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Jan 23, 2019

The builds were timing out for a random reason so I restarted them.

@taylorotwell taylorotwell merged commit c3f3022 into laravel:5.7 Jan 23, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@staudenmeir staudenmeir deleted the staudenmeir:26158 branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment