Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[5.7] Add line about expiring password reset in notification email #27324
+1
−0
Conversation
GrahamCampbell
changed the title
Add line about expiring password reset in notification email
[5.7] Add line about expiring password reset in notification email
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
There is probably another way to phrase it so that you could use getFromJson... Something like: "Minutes until password reset link expires: #" |
taylorotwell
merged commit 607caff
into
laravel:5.7
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
I just used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
michaeldyrynda commentedJan 28, 2019
•
edited
I've recently started using the password resets in one of our apps at work, and the most common feedback we receive is that "it doesn't work". This is always because the link is expired.
Per suggestions from Postmark, I've added a line that pulls the expiry config value in to the notification email.
I'm not sure of the significance of using
transChoice
overgetFromJson
here, but I couldn't get the choice to work otherwise.Happy to make changes if anybody else (ping @themsaid) has feedback on another approach; I don't want to have a line that doesn't work for those using JSON language files if the
transChoice
method doesn't work with that properly.