New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Revert "Handle AWS Connection Lost (#25295)" #27418

Merged
merged 3 commits into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@iBotPeaches
Copy link
Contributor

iBotPeaches commented Feb 4, 2019

Fixes #27053, Refs #25289 & #25295

Queue workers die with userland exception

production.ERROR: Error creating resource: [message] fopen(): php_network_getaddresses: getaddrinfo failed: Name or service not known

Any failure in userland to fopen will cause the queue worker to kill itself, because it gets detected by "DetectsLostConnections". This is because this string is too generic in the detection of lost connections when it was intended for database lost connections, but instead it falls for random userland exceptions.

I had first opted to fix the DetectsLostConnection to check exception for DB context, but I don't know enough about internals of Laravel to do that. So I opted instead to revert the commits that added this.

See this comment for more details: #27053 (comment)

@taylorotwell taylorotwell merged commit e07e334 into laravel:5.7 Feb 5, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment