Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix a bug with string via in queued notifications #27710

Merged
merged 2 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@driesvints
Copy link
Member

driesvints commented Feb 28, 2019

A queued notification with a string via currently fails because it's not converted to an array. I've added a test which proves the failure.

Reported via laravel/docs#5023

driesvints added some commits Feb 28, 2019

Fix a bug with string via in queued notifications
A queued notification with a string via currently fails because it's not converted to an array. I've added a test which proves the failure.

Reported via laravel/docs#5023

@taylorotwell taylorotwell merged commit ee6a5e0 into laravel:5.8 Feb 28, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@driesvints driesvints deleted the driesvints:fix-notification-sender branch Feb 28, 2019

@AbdelElrafa AbdelElrafa referenced this pull request Feb 28, 2019

Merged

[5.8] Fix dockblock #27720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.