Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Check if MessageBag is empty before checking keys exist #27719

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@robbie-thompson
Copy link
Contributor

robbie-thompson commented Feb 28, 2019

Optimization that checks if the message bag has any messages in the first place, to prevent unnecessary looping through all the keys and seeing if each one exists.

@robbie-thompson robbie-thompson changed the title Check if MessageBag is empty before checking keys exist [5.8] Check if MessageBag is empty before checking keys exist Feb 28, 2019

@taylorotwell taylorotwell merged commit 52ae81d into laravel:5.8 Feb 28, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.