[5.8] Adds the ability to set the reconnector created by a DatabaseManager.#27845
Merged
Conversation
DatabaseManager.DatabaseManager.
Member
|
So, in a service provider, what prevents you from doing something like: $this->app->resolved('db', function ($db) {
$db->connection('foo')->setReconnector(fn);
}); |
Contributor
Author
|
I have multiple connections, so I'd need to iterate through (and configure) all of them in this block of code, when any given request may not actually utilize (and thus not have to configure) those connections. Yes, the overhead of the configuration is (relatively) minor, but still unnecessary until I actually need to perform a query against the Db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements laravel/ideas#1557.
Our current use-case for wanting to customize the reconnector is wanting to add a "maximum retries" setting. When experiencing some edge-case database issues, they were exacerbated by the default reconnector "infinitely" trying to reconnect (infinitely in quotes because eventually something times out, but still has the tendency to turn a minor blip into a feedback loop).