[5.8] Fix JSON boolean queries#27847
Merged
Merged
Conversation
|
Thanks for the fix, @staudenmeir! Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel 5.8's unquoting of JSON values on MySQL (#25732) broke boolean comparisons:
The
json_unquote()call is actually only necessary for theSELECTclause, but I don't see a feasible/elegant way to compile different statements for theSELECTand theWHEREclause.So I suggest we fix this by adding a new
JsonBooleantype.The default implementation works on SQLite 3.23+.
The
is_string($column)check is necessary to preserve raw expressions:I used the opportunity to also add support for PostgreSQL and SQL Server.
Fixes #27696.