Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add replacement for lower danish "æ" #27886

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@andershagbard
Copy link
Contributor

andershagbard commented Mar 14, 2019

No description provided.

@GrahamCampbell GrahamCampbell changed the title Add replacement for lower danish "æ" [5.8] Add replacement for lower danish "æ" Mar 14, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Mar 14, 2019

Thanks for the PR. Has this been accepted to the upstream library? We're only making changes that matches the upstream implementation.

@andershagbard

This comment has been minimized.

Copy link
Contributor Author

andershagbard commented Mar 14, 2019

@GrahamCampbell Not sure what that means. What is the upstream library?

@taylorotwell taylorotwell merged commit c0523cd into laravel:5.8 Mar 14, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BrandonSurowiec

This comment has been minimized.

Copy link
Contributor

BrandonSurowiec commented Mar 15, 2019

@andershagbard Graham is referring to the https://github.com/danielstjules/Stringy/blob/master/src/Stringy.php#L1871 repo as the upstream library, which is the parent repository where this code is taken from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.