Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix updateOrInsert method for query builder #27906

Conversation

Projects
None yet
2 participants
@Organizm238
Copy link
Contributor

Organizm238 commented Mar 17, 2019

Fixes #27890

Now updateOrInsert meethod correctly works with empty values array.
Before it created syntactically wrong update SQL, now it doesn't trigger any update Query and simply returns 'true'.

I have also added the test cehcking the new behaviour of method.

Organizm238 added some commits Mar 17, 2019

Fix updateOrInsert method for Query Builder
Now it correctly works with empty values array.
Before it created syntactically wrong SQL, now it simply returns 'true'.
Fix test for updateOrInsert method for Query Builder
Now it checks for `update` method not being called,
if updateOrInsert update values array is empty.

@Organizm238 Organizm238 changed the title Fix update or insert method for query builder Fix updateOrInsert method for query builder Mar 17, 2019

@GrahamCampbell GrahamCampbell changed the title Fix updateOrInsert method for query builder [5.8] Fix updateOrInsert method for query builder Mar 18, 2019

@taylorotwell taylorotwell merged commit c04835e into laravel:5.8 Mar 18, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.