[5.8] Fix updateOrInsert method for query builder#27906
Merged
taylorotwell merged 2 commits intoMar 18, 2019
Merged
Conversation
Now it correctly works with empty values array. Before it created syntactically wrong SQL, now it simply returns 'true'.
Now it checks for `update` method not being called, if updateOrInsert update values array is empty.
Organizm238
changed the title
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27890
Now updateOrInsert meethod correctly works with empty values array.
Before it created syntactically wrong update SQL, now it doesn't trigger any update Query and simply returns 'true'.
I have also added the test cehcking the new behaviour of method.