[5.8] getNamespace is independent#27915
Merged
taylorotwell merged 1 commit intoMar 18, 2019
Merged
Conversation
Member
|
@XuanQuynh please always provide the full description to your initial comment and not link to an external issue/pr. |
Contributor
Author
|
@driesvints I updated (just copy from my earlier pr) . OK, I will provide on the later pull requests/issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application::getNamespace()currently uses global helpers in which the first call to this method is the call to global container instance only becauseApplicationconstructor sets it viaApplication::registerBaseBindings().Application::getNamespace()is independent and returns the namespace itself. This pull request solves by using the exact methods of Application rather than global helpers.See the example below for more details:
{ "autoload": { "psr-4": { "Laravel\\One\\": "app/" } } }{ "autoload": { "psr-4": { "Laravel\\Two\\": "app/" } } }Expected
Actual