[5.8] Use Null coalescing operator to refactor - #27955
Merged
Merged
Conversation
richardkeep
changed the title
driesvints
approved these changes
Mar 21, 2019
martinbean
reviewed
Mar 22, 2019
| return $this->convertedFiles | ||
| ? $this->convertedFiles | ||
| : $this->convertedFiles = $this->convertUploadedFiles($files); | ||
| return $this->convertedFiles = $this->convertedFiles ?? $this->convertUploadedFiles($files); |
Contributor
There was a problem hiding this comment.
Could this not be shortened further to just return $this->convertedFiles ?? $this->convertUploadedFiles($files);?
Contributor
Author
There was a problem hiding this comment.
No, we also want to set the value for $this->convertUploadedFiles($files) to $this->convertedFiles if it is falsy before returning.
Contributor
|
This change may have side effects as it's not identical to the original behavior. |
Member
|
@rellect I think it's the same result in the end, right? Although your solution makes a bit more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.